[foxy] Use interface whitelist for localhost only (#476) #514
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use interface whitelist for localhost only Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
fujitatomoya
changed the title
|
requesting review just in case. i confirmed this fixes the ros2/ros2#1096 (originally ros2/ros2#1052) with foxy repo. |
|
CI:
|
This was referenced Mar 5, 2021
|
CI looks okay, waiting for the review. |
mitsudome-r
approved these changes
Mar 5, 2021
|
@mitsudome-r thanks for checking, let's wait it out for a bit. i do need another review on this. @richiware @MiguelCompany friendly ping for review. |
MiguelCompany
approved these changes
Mar 8, 2021
|
windows CI is unrelated to this fix, going in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foxy backport of #476