Add in a missing data_reader check when creating subscription. #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The end stanza of create_datareader() is supposed to be attempting to create a datareader with the underlying Fast-DDS library. If creation of the datareader returns a valid pointer, we've succeeded, and if it returns a nullptr, it has failed. However, there were two separate problems of the logic checking for these conditions: 1. It was checking the datareader pointer-to-a-pointer, which should always be non-null. What it really meant to check was the datareader pointer (dereferenced). 2. There is a fallback mechanism for when unique network flow endpoints were optionally required. The problem with that is that when using the fallback, we never check again to make sure the fallback was successful. Therefore, if we failed for another reason (like security), we would not discover it until a crash later on. This commit fixes both of these issues. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
MiguelCompany
approved these changes
Jul 18, 2023
iuhilnehc-ynos
approved these changes
Jul 18, 2023
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end stanza of create_datareader() is supposed to be attempting to create a datareader with the underlying Fast-DDS library. If creation of the datareader returns a valid pointer, we've succeeded, and if it returns a nullptr, it has failed.
However, there were two separate problems of the logic checking for these conditions:
This commit fixes both of these issues.
This commit will improve the error reporting as in ros2/sros2#287 , though it does not completely solve it (I think we need more work at the rclcpp layer).