-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't find_package(ament_index_cpp ..) if RMW is configured at build-time #210
Don't find_package(ament_index_cpp ..) if RMW is configured at build-time #210
Conversation
So don't find_package(..) it if RMW_IMPLEMENTATION_DISABLE_RUNTIME_SELECTION is OFF. Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
I'm currently on Humble, so if this could be backported to |
Not sure what to make of the buildfarm build failing. |
We need to do some Rolling releases. I'll do those in a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@ros-pull-request-builder retest this please |
1 similar comment
@ros-pull-request-builder retest this please |
Looks like the Jenkins agents get shut down before the build completes? |
Sigh, yes. The aarch64 nodes have been flapping a bit lately. They automatically restart, but the tracking badge doesn't follow that. Updated now. |
CI looks good here (the yellow jobs just have a CMake warning, and that was fixed elsewhere). So going ahead and merging this one. |
thanks. Could this one also be backported to Humble? |
@Mergifyio backport humble |
✅ Backports have been created
|
So don't find_package(..) it if RMW_IMPLEMENTATION_DISABLE_RUNTIME_SELECTION is OFF. Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl> (cherry picked from commit 11652db)
So don't find_package(..) it if RMW_IMPLEMENTATION_DISABLE_RUNTIME_SELECTION is OFF. Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl> (cherry picked from commit 11652db) Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
As per subject.
Should fix #209.