support wait_for_service #137
Conversation
|
This is also ready for review. The latest commit 6f65a4e fixed the bug I was struggling with where the publisher and subscription count was always going up and never down. |
| ) noexcept | ||
| { | ||
| if (!is_available) { | ||
| return "argument is_available is null"; |
There was a problem hiding this comment.
should be return nullptr with setting error message?
There was a problem hiding this comment.
No, these functions are strange like that. See: https://github.com/ros2/rmw_opensplice/blob/master/rosidl_typesupport_opensplice_cpp/include/rosidl_typesupport_opensplice_cpp/service_type_support.h#L62-L66
|
lgtm, there are several error catches with fprintfs such that a user cannot deal with them. Most are clean up errors. Presumeably if we cannot deallocate things there's something bad happening. I don't think we have a way to expose that sort of failure at the moment though. |
|
Yeah, I try to only use |
Connects to ros2/ros2#215