This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
refactor to support init options and context #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
added
enhancement
jacobperron
approved these changes
Nov 21, 2018
wjwwood
force-pushed
the
refactor_init
branch
from
206f949
to
85da39d
Compare
sloretz
previously approved these changes
Nov 29, 2018
sloretz
reviewed
Nov 29, 2018
rmw_opensplice_cpp/src/rmw_init.cpp
Outdated
| context->implementation_identifier, | ||
| opensplice_cpp_identifier, | ||
| return RMW_RET_INCORRECT_RMW_IMPLEMENTATION); | ||
| RCUTILS_CHECK_ARGUMENT_FOR_NULL(context->impl, RMW_RET_INVALID_ARGUMENT); |
There was a problem hiding this comment.
Looks like this has the same check for null but context->impl should be null here
Signed-off-by: William Woodall <william@osrfoundation.org>
wjwwood
force-pushed
the
refactor_init
branch
from
85da39d
to
cc7f9a3
Compare
Signed-off-by: William Woodall <william@osrfoundation.org>
sloretz
approved these changes
Nov 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw#154