Fix topic matching #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
added
in progress
dirk-thomas
approved these changes
Jun 10, 2017
|
Can confirm that this makes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just removes code that was inplace to adapt ros 1 topics and services that have leading
/to ros 2 topics and services which did not, until recently.This should fix ros2/build_farmer#28.
This should also remove the need to use
--bridge-all-topics, @Karsten1987 @Kukanani fyi.I also fixed an issue where the dynamic bridge would crash if the header info for a service was incomplete. The case was being caught and a message was being printed to stderr, but later the code would crash because there was a partially filled out entry in the map. So I just remove it when this case happens now. That prevents the crash, but I don't know why the service info is incomplete in these cases.
Packaging job: