[WIP] Add a tutorial for the ParameterEventHandler class #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the new class, ParameterEventsSubscriber. Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
|
CI is failing because there is a bunch of trailing whitespace in the tutorial. Also, is it safe to say that this tutorial is only going to work in Galactic? If that's the case, we need to make very sure it says it at the top, otherwise we'll get people confused if they are using Foxy or earlier. Finally, would you mind pushing this branch to your own fork and opening the PR from there? I'm trying to cleanup the branches on this repository. |
|
Yes, Galactic only; I'll add that. I'm remove the whitespace, push to a fork, and re-submit. |
|
Closing now that #1123 is open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tutorial depends on the following functionality ros2/rclcpp#829, which must be integrated before this PR.
Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org