Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2pkg: avoid requiring git #111

Merged
merged 1 commit into from
Jun 25, 2018
Merged

ros2pkg: avoid requiring git #111

merged 1 commit into from
Jun 25, 2018

Conversation

dirk-thomas
Copy link
Member

Fixes #109.

I didn't run CI for this but ran the package tests as well as the actual verb locally.

@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Jun 25, 2018
@dirk-thomas dirk-thomas self-assigned this Jun 25, 2018
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change lgtm, didnt test it though

@dirk-thomas dirk-thomas merged commit 14ca069 into master Jun 25, 2018
@dirk-thomas dirk-thomas deleted the avoid_dep_on_git branch June 25, 2018 18:32
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jun 25, 2018
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
* Add frontend remap test

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Pass data_type parameter to remap entity

This resolves an issue where frontend remaps are not parsed.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants