Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky crash at shutdown using subscriber_old_school #114

Closed
sloretz opened this issue Jun 26, 2018 · 2 comments
Closed

Flaky crash at shutdown using subscriber_old_school #114

sloretz opened this issue Jun 26, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@sloretz
Copy link
Contributor

sloretz commented Jun 26, 2018

Bug report

Required Info:

Steps to reproduce issue

Run subscriber old school

ros2 run examples_rclpy_minimal_subscriber subscriber_old_school

CTRL + c. Sometimes there is a crash instead of a clean shutdown.

Expected behavior

Executable would shut down cleanly.

Actual behavior

C:\dev\ros2-windows>ros2 run examples_rclpy_minimal_subscriber subscriber_old_school
[INFO] [minimal_subscriber]: I heard: "Hello World: 64"
[INFO] [minimal_subscriber]: I heard: "Hello World: 65"
[INFO] [minimal_subscriber]: I heard: "Hello World: 66"
[INFO] [minimal_subscriber]: I heard: "Hello World: 0"
[INFO] [minimal_subscriber]: I heard: "Hello World: 1"
[INFO] [minimal_subscriber]: I heard: "Hello World: 2"
[INFO] [minimal_subscriber]: I heard: "Hello World: 0"
[INFO] [minimal_subscriber]: I heard: "Hello World: 1"
[INFO] [minimal_subscriber]: I heard: "Hello World: 2"
========================================================================================
Context     : DDS::WaitSet::wait
Date        : Mon Jun 25 17:50:55 Pacific Daylight Time 2018
Node        : DESKTOP-S5KSNBT
Process     : python.exe <3116>
Thread      : 2992
Internals   : WaitSet.cpp/252/6.7.180404OSS/5926d257/5926d257/-1
----------------------------------------------------------------------------------------
Report      : Already deleted: Object is already deleted.
Internals   : DDS::OpenSplice::CppSuperClass::check/CppSuperClass.cpp/232/9/1529974255.092807600
----------------------------------------------------------------------------------------
Report      : Precondition not met: Waitset is already deleted
Internals   : u_waitsetWaitAction2/u_waitset.c/333/782/1529974255.102913900

Additional information

@sloretz sloretz added the bug Something isn't working label Jun 26, 2018
@nuclearsandwich
Copy link
Member

Building from source with opensplice on Windows and I was not able to reproduce this behavior running and stopping this process multiple times with various run intervals between.

@claireyywang
Copy link
Contributor

closing as the issue does not seem to be reproducible, will reopen if it persists in latest versions.

esteve pushed a commit to esteve/ros2cli that referenced this issue Dec 16, 2022
Fixes ros2#114.

Due to the asynchronous nature of the LoadComposableNodes action, an event handler causes the launch configuration is popped if ComposableNodeContainer appears inside a group or include action.
It seems to me we can simply return the load node action, which will get executed after the ComposableNodeContainer action. The use of an event handler is vestigial of a refactoring done in ros2/launch_ros#16, and doesn't appear to be necessary.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants