Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use collections.abc.Iterable #177

Merged
merged 1 commit into from
Dec 13, 2018
Merged

use collections.abc.Iterable #177

merged 1 commit into from
Dec 13, 2018

Conversation

dirk-thomas
Copy link
Member

Same as ros2/launch#158.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Dec 13, 2018
@dirk-thomas dirk-thomas self-assigned this Dec 13, 2018
@wjwwood
Copy link
Member

wjwwood commented Dec 13, 2018

Needs to be tested against Xenial, imo.

@dirk-thomas
Copy link
Member Author

dirk-thomas commented Dec 13, 2018 •
edited
Loading

Needs to be tested against Xenial, imo.

Can you elaborate why? collections.abc exists since Python 3.3 and Xenial uses Python 3.5.

@wjwwood
Copy link
Member

wjwwood commented Dec 13, 2018

Was Iterable in collections.abc? I dunno I guess you can also just check the documentation to see if it should work or not. I just think running a Xenial job up to launch would accomplish the same thing and be certain.

@dirk-thomas
Copy link
Member Author

Confirmed in a Xenial Docker:

# python3 --version
Python 3.5.2
# python3 -c "import collections.abc; print(collections.abc.Iterable)" 
<class 'collections.abc.Iterable'>

@dirk-thomas dirk-thomas merged commit 8dc506f into master Dec 13, 2018
@dirk-thomas dirk-thomas deleted the collections-abc branch December 13, 2018 01:42
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Dec 13, 2018
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
@wjwwood
launch: ensure event handlers add event to context locals (ros2#177)
8b3ec03 
* launch: ensure event handlers add event to context locals

Also add tests for all event handlers.

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>

* Use super().handle() instead

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>

* Split BaseEventHandler from EventHandler

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
@jacobperron
Fix AttributeError when accessing component container name (ros2#177)
18be4d4 
`self.__target_container` is not necessarily an ExecuteProcess action, and therefore may not have a 'name' attribute.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirk-thomas @wjwwood @jacobperron