Able to show info of hidden topic. #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: evshary <evshary@gmail.com>
|
@evshary Thanks for the PR. I think it makes sense to not show the hidden topics by default since they are hidden for a reason. Most users shouldn't need to worry about them because they are an implementation detail. But in cases where we want to probe the hidden topics, it's nice to have the option. So, I think we should add the extra option as described (it is also consistent with other verbs like |
|
Disregard my previous comment (I still need a coffee). Since we provide the topic name explicitly, an extra option shouldn't be necessary :) |
jacobperron
approved these changes
Dec 16, 2019
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According #411, support show hidden topic info with
ros2 topic info <hidden topic>However, I'm not sure whether it's fine to show hidden topic directly or it's necessary to add extra option, like
--include-hidden-topics.