Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2topic] Add option to echo serialized messages #470

Merged
merged 8 commits into from
Jul 22, 2020

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron commented Mar 23, 2020

I found this feature useful when doing some debugging.

Depends on ros2/rosidl_runtime_py#10

ros2topic/test/test_echo_pub.py Outdated Show resolved Hide resolved
ros2topic/test/test_echo_pub.py Show resolved Hide resolved
@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron requested a review from hidmic July 18, 2020 00:43
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing conflicts and passing CI!

I found this feature useful when doing some debugging.

Depends on ros2/rosidl_runtime_py#10

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Instead of relying on the message_to_* utilities to handle raw messages.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

@jacobperron
Copy link
Member Author

After rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit f03938e into master Jul 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/echo_raw branch July 22, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants