Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ros2 topic echo to report lost messages #542

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

ivanpauno
Copy link
Member

Complements ros2/rmw#226.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in progress Actively being worked on (Kanban column) label Jun 25, 2020
@ivanpauno ivanpauno self-assigned this Jun 25, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno marked this pull request as ready for review June 26, 2020 17:27
@ivanpauno ivanpauno added enhancement New feature or request in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jun 26, 2020
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI.

I guess the Rpr job failures are unrelated.

@ivanpauno
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Member Author

@ivanpauno
Copy link
Member Author

@ros-pull-request-builder retest this please

@ivanpauno
Copy link
Member Author

Rpr test failing isn't related to this PR, it's also failing in other PRs that are open. Merging!

@ivanpauno ivanpauno merged commit 673d4fd into master Jun 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/topic-echo-lost-messages-option branch June 29, 2020 19:34
craigh92 pushed a commit to craigh92/ros2cli that referenced this pull request Jul 17, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Craig Hickman <craig.hickman@ukaea.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants