Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on launch packages instead of ros_testing to avoid circular dependency #685

Merged
merged 2 commits into from
Dec 24, 2021
Merged

Depend on launch packages instead of ros_testing to avoid circular dependency #685

merged 2 commits into from
Dec 24, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Dec 23, 2021

ros_testing depends on ros2test which depends on ros2cli. This causes a circular dependency in the repository that means ros-rolling-ros2cli gets installed in the PR job for this repo.

@sloretz
Depend on launch packages instead of ros_testing to avoid circular de…
e22377d 
…pendency

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Dec 23, 2021
clalancette
clalancette requested changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 packages here that don't actually depend on launch_ros. It's a bit nit-picky, but since we are reducing dependencies we may as well only include the things that we need.

ros2action/package.xml Outdated Show resolved Hide resolved
ros2interface/package.xml Outdated Show resolved Hide resolved
ros2pkg/package.xml Outdated Show resolved Hide resolved
@sloretz
packages don't depend on launch_ros
6f5a060 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette
clalancette approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@sloretz
Copy link
Contributor Author

sloretz commented Dec 23, 2021

CI (build: --packages-up-to ros2action ros2doctor ros2interface ros2lifecycle ros2node ros2pkg ros2service ros2topic test: --packages-select ros2action ros2doctor ros2interface ros2lifecycle ros2node ros2pkg ros2service ros2topic)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 298764c into master Dec 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_test_dependency_cycle branch December 24, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@cottsay cottsay Awaiting requested review from cottsay

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @clalancette