Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ros2topic echo once option. #695

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

fujitatomoya
Copy link
Collaborator

address #529

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com
Co-authored-by: Craig Hickman craig.hickman@ukaea.uk

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Craig Hickman <craig.hickman@ukaea.uk>
@fujitatomoya
Copy link
Collaborator Author

@craigh92 i added you as Co-Author since i borrowed part of your code.

@fujitatomoya
Copy link
Collaborator Author

@clalancette @ivanpauno could you take a look when you have time?

Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@audrow audrow linked an issue Feb 24, 2022 that may be closed by this pull request
@audrow audrow merged commit 4743da4 into ros2:master Feb 24, 2022
@audrow
Copy link
Member

audrow commented Feb 24, 2022

Thanks, @fujitatomoya!

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/best-way-to-simulate-once-in-galactic/28374/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - ros2 topic echo --once
3 participants