Fix flaky ros2 param list #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps avoid incomplete parameter lists due to races with discovery. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
It's possible that the first invocation of 'ros2 param list' does not return a complete parameter list as there may not have been enough time for discovery. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
fujitatomoya
approved these changes
Jul 22, 2021
|
@jacobperron @audrow all green, i go ahead to merge this. |
jacobperron
added a commit
that referenced
this pull request
Aug 31, 2021
* Use daemon for listing parameter services This helps avoid incomplete parameter lists due to races with discovery. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Retry list verb test It's possible that the first invocation of 'ros2 param list' does not return a complete parameter list as there may not have been enough time for discovery. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Lint Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Aug 31, 2021
* Use daemon for listing parameter services This helps avoid incomplete parameter lists due to races with discovery. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Sep 9, 2021
* Use daemon for listing parameter services This helps avoid incomplete parameter lists due to races with discovery. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Retry list verb test It's possible that the first invocation of 'ros2 param list' does not return a complete parameter list as there may not have been enough time for discovery. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Lint Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this relates to #655, and hopefully fixes it.
By using the daemon node to list parameter services, I hope we avoid a race with discovery with every invocation of
ros2 param list. There still is a race with the first call if the daemon is not running yet, but I think that's normal for most ros2cli tools.I've also add a retry decorator to the test to workaround it potentially failing on the first try.