New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[galactic backport] Fix flaky ros2 param list (#656) #663

Merged

jacobperron merged 1 commit into galactic from jacob/galactic_backport_656

Sep 9, 2021

Member

jacobperron commented Aug 31, 2021

Backport #656 to Galactic


          Fix flaky ros2 param list (#656)

eb4e8cf

* Use daemon for listing parameter services

This helps avoid incomplete parameter lists due to races with discovery.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Retry list verb test

It's possible that the first invocation of 'ros2 param list' does not return a complete parameter list
as there may not have been enough time for discovery.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Lint

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

jacobperron self-assigned this

jacobperron requested review from mabelzhang and audrow

August 31, 2021 18:50

Member Author

jacobperron commented Aug 31, 2021 •

edited

Loading

Linux
Linux-aarch64
macOS
Windows

audrow approved these changes

View reviewed changes

jacobperron merged commit 313d4bf into galactic

delete-merged-branch bot deleted the jacob/galactic_backport_656 branch

September 9, 2021 17:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet