Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky ros2 param list #656

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Fix flaky ros2 param list #656

merged 3 commits into from
Jul 22, 2021

Commits on Jul 21, 2021

  1. Use daemon for listing parameter services 

    This helps avoid incomplete parameter lists due to races with discovery.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    fd1aeb1 View commit details
    Browse the repository at this point in the history

  2. Retry list verb test 

    It's possible that the first invocation of 'ros2 param list' does not return a complete parameter list
as there may not have been enough time for discovery.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    f4aadca View commit details
    Browse the repository at this point in the history

  3. Lint 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b660f5b View commit details
    Browse the repository at this point in the history