Fix incorrect boundary check for playback_duration and play_until_timestamp
#1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
- Properly handle cases when playback_duration = 0 or play_until_timestamp_ = 0. - Rewrite `play_for_none_are_played_due_to_duration` test to use `on_playback` callbacks to decrease runtime from 10 seconds down to 100 milliseconds. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
requested review from
emersonknapp,
hidmic and
gbiggs
and removed request for
a team
|
cc: @agalbachicar |
Using on_play_callbacks instead of expectation for 0 messages on subscription. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Change wrong expectations for number of messages to arrive. It was expecting to arrive 1 but actually should expect 2. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
There was a problem hiding this comment.
@MichaelOrlov thanks for sending this bug and fixing the bug we introduced. I left two suggestions for your consideration which try to improve readability only.
Thanks again!
jhdcs
requested changes
Jun 27, 2022
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/e28428938082cd90d5c8013362a8053a/raw/9900e5b8703accdc299db1280f09f1cbca688e74/ros2.repos
|
jhdcs
approved these changes
Jun 28, 2022
delete-merged-branch
bot
deleted the
morlov/fix-for-incorrect-play_until_timestamp-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playback_durationandplay_until_timestamp#1031Update: Also fixed one false positive and one flaky test in
test_play_until