Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store metadata in db3 files directly #1109

Closed
MichaelOrlov opened this issue Oct 2, 2022 · 3 comments · Fixed by #1294
Closed

Store metadata in db3 files directly #1109

MichaelOrlov opened this issue Oct 2, 2022 · 3 comments · Fixed by #1294
Labels
enhancement New feature or request

Comments

@MichaelOrlov
Copy link
Contributor

MichaelOrlov commented Oct 2, 2022

Description

We have a proposal to make rosbag2 .db3 files self-contained. To achieve this goal we need to store metadata in .db3 files directly.

Related Issues

Relates:

Completion Criteria

All metadata fields stored in .db3 files directly.

Implementation Notes / Suggestions

On "Rosbag2 and Tooling WG meeting" from 2022-09-23 we discussed possible implementation and came to the following design decisions and proposals:

  1. We decided to store metadata as a string in yaml format in newly created schema table from Store DB schema versioning in .db3 files #1108.
    It will be relatively easily to do since we already have all necessary methods for creating and parsing metadata from string read out from yaml file.
  2. We will keep writing metadata.yaml file as before and rely on metadata from it.
  3. We will fallback on metadata from .db3 file directly if metadata.yaml absent or our parser failed to read or parse data from yaml file.
    The rational for this is that it's very convenient to operate with metadata stored in yaml file. i.e. It's very convenient to open yaml file in simple text editor to see what inside or edit it if necessary.

Testing Notes / Suggestions

  • Will need to add unit tests to cover read out and parsing metadata from .db3 files directly
  • Will need to add unit tests to make sure that old versions of bag files supported. Need to make sure that we support backward compatibility.
@ros-discourse
Copy link

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2022-10-13/28213/1

@ros-discourse
Copy link

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2022-11-17/28457/1

@ros-discourse
Copy link

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2022-12-15/28840/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants