-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store db schema version and ROS_DISTRO name in db3 files #1156
Conversation
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Added following unit tests: - `get_db_schema_version_returns_correct_value` - `get_recorded_ros_distro_returns_correct_value` - `check_backward_compatibility_with_schema_version_2` Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
81f77af
to
5e71460
Compare
@clalancette Could you please review this PR for ABI and API stability to be able to backport this PR to Humble? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve this as fine, I don't think we need to go back and forth too much on this part of it since it doesn't affect how other storage implementations have to do anything, there are no core APIs.
I have noted in the comment stream that I agree with Adrian that I might approach it a little differently, but those opinions are non-blocking for me.
Gist: https://gist.githubusercontent.com/MichaelOrlov/43376b9180367dfdbc6f83ac9e0b571f/raw/9de6d51acca2cd167442395b576ed59daa25d077/ros2.repos |
https://github.com/Mergifyio backport humble |
* Add new tables for `schema` and `metadata` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add `SqliteWrapper::table_exists(table_name)` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add `get_db_schema_versio()` and `get_recorded_ros_distro()` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add unit tests for checking new and old db schema versions Added following unit tests: - `get_db_schema_version_returns_correct_value` - `get_recorded_ros_distro_returns_correct_value` - `check_backward_compatibility_with_schema_version_2` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 9498426) # Conflicts: # rosbag2_storage_default_plugins/include/rosbag2_storage_default_plugins/sqlite/sqlite_storage.hpp # rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp
✅ Backports have been created
|
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
…ckport #1156) (#1175) * Store db schema version and ROS_DISTRO name in db3 files (#1156) * Add new tables for `schema` and `metadata` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add `SqliteWrapper::table_exists(table_name)` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add `get_db_schema_versio()` and `get_recorded_ros_distro()` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add unit tests for checking new and old db schema versions Added following unit tests: - `get_db_schema_version_returns_correct_value` - `get_recorded_ros_distro_returns_correct_value` - `check_backward_compatibility_with_schema_version_2` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 9498426) # Conflicts: # rosbag2_storage_default_plugins/include/rosbag2_storage_default_plugins/sqlite/sqlite_storage.hpp # rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp * Fix merge conflicts after backporting pr #1156 from rolling Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2022-12-15/28840/1 |
Closes Store DB schema versioning in .db3 files #1108
Relates Store ROS_DISTRO as metadata.yaml and in the storage file #1086
Add new tables for
schema
andmetadata