-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pause and resume recording via service call. #1130
Comments
@rshanor Agree that it would be nice to have such feature. rosbag2/rosbag2_transport/src/rosbag2_transport/player.cpp Lines 798 to 829 in 5b8b658
Also to accomplish this feature it would be nice to add rosbag2/rosbag2_transport/include/rosbag2_transport/play_options.hpp Lines 83 to 84 in 5b8b658
and rosbag2/ros2bag/ros2bag/verb/play.py Lines 129 to 131 in 5b8b658
|
Ack, I will work on getting this PRed soon. Thanks! |
Add service calls to pause recording and resume recording. Fixes ros2#1130 Signed-off-by: Rick Shanor <rickshanor@gmail.com>
@rshanor Thank you. Your contribution very welcome. |
This feature will be very useful for distributed recording 😉 |
Add service calls to pause recording and resume recording. Fixes ros2#1130 Signed-off-by: Rick Shanor <rickshanor@gmail.com>
* feat(recorder): Add pause and resume service calls. Add service calls to pause recording and resume recording. Fixes #1130 Signed-off-by: Rick Shanor <rickshanor@gmail.com> * feat(recorder): pause, resume, and is_paused PR comments. Address PR comments. Add is_paused service. Update tests accordingly. Signed-off-by: Rick Shanor <rickshanor@gmail.com> Signed-off-by: Rick Shanor <rickshanor@gmail.com>
* feat(recorder): Add pause and resume service calls. Add service calls to pause recording and resume recording. Fixes ros2#1130 Signed-off-by: Rick Shanor <rickshanor@gmail.com> * feat(recorder): pause, resume, and is_paused PR comments. Address PR comments. Add is_paused service. Update tests accordingly. Signed-off-by: Rick Shanor <rickshanor@gmail.com> Signed-off-by: Rick Shanor <rickshanor@gmail.com>
* feat(recorder): Add pause and resume service calls. Add service calls to pause recording and resume recording. Fixes ros2#1130 Signed-off-by: Rick Shanor <rickshanor@gmail.com> * feat(recorder): pause, resume, and is_paused PR comments. Address PR comments. Add is_paused service. Update tests accordingly. Signed-off-by: Rick Shanor <rickshanor@gmail.com> Signed-off-by: Rick Shanor <rickshanor@gmail.com>
Recorder already has a pause and resume feature: #905
Feature would look a lot like the SplitBagfile service: #1115
Figured I would add a file
rosbag2_interfaces/srv/EnableRecorder.srv
that looks something like@MichaelOrlov thoughts? My robot sits around running but not doing anything useful 90% of the time.
The text was updated successfully, but these errors were encountered: