Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store message definitions in SQLite3 storage plugin #1293

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Store message definitions in SQLite3 storage plugin #1293

merged 3 commits into from
Apr 14, 2023

Conversation

MichaelOrlov
Copy link
Contributor

@MichaelOrlov MichaelOrlov commented Apr 14, 2023 •
edited
Loading

@MichaelOrlov MichaelOrlov changed the title Store message definitions in sqlite3 storage Store message definitions in SQLite3 storage plugin Apr 14, 2023
@MichaelOrlov
Store message definitions in SQLite3 database
cc7dce3 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Add unit tests
1a28379 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov force-pushed the morlov/store_msg_definitions_in_sqlite3_storage branch from 3b8e54e to 1a28379 Compare April 14, 2023 19:33
@MichaelOrlov MichaelOrlov marked this pull request as ready for review April 14, 2023 19:34
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner April 14, 2023 19:34
@MichaelOrlov MichaelOrlov requested review from gbiggs, emersonknapp and james-rms and removed request for a team and gbiggs April 14, 2023 19:34
@MichaelOrlov
Update talker.db3 and test_get_message_definitions for new db schema 4
c6b9f65 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Copy link
Contributor Author

Gist: https://gist.githubusercontent.com/MichaelOrlov/a5ed6a7511e6b72510432a2f06a79285/raw/3f5186a272a0694aa678946cae23a65e1dcdbe44/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_py rosbag2_storage_sqlite3
TEST args: --packages-above rosbag2_py rosbag2_storage_sqlite3
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11911

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

emersonknapp
emersonknapp approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelOrlov MichaelOrlov merged commit e1a99d4 into rolling Apr 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the morlov/store_msg_definitions_in_sqlite3_storage branch April 14, 2023 23:28
@MichaelOrlov MichaelOrlov mentioned this pull request Apr 20, 2023
Closed
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-4-20-2023/31087/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@james-rms james-rms Awaiting requested review from james-rms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store message definition in bag
3 participants
@MichaelOrlov @ros-discourse @emersonknapp