Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ament_cmake_vendor_package #1400

Merged
merged 1 commit into from Jun 21, 2023
Merged

Switch to ament_cmake_vendor_package #1400

merged 1 commit into from Jun 21, 2023

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jun 15, 2023

Part of ament/ament_cmake#429

  • Linux Build Status
  • Linux Build Status (FORCE_BUILD_VENDOR_PKG)
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status
  • Windows Build Status (DEBUG)

@cottsay
Switch to ament_cmake_vendor_package
3b38d9a 
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay requested a review from clalancette June 15, 2023 16:53
@cottsay cottsay self-assigned this Jun 15, 2023
@cottsay cottsay requested a review from a team as a code owner June 15, 2023 16:53
@cottsay cottsay requested review from gbiggs and emersonknapp and removed request for a team June 15, 2023 16:53
emersonknapp
emersonknapp approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice improvement!

@cottsay
Copy link
Member Author

cottsay commented Jun 15, 2023

The CI failure is a legitimate problem, but it's actually in the ament_cmake_vendor_package tests. I'll have to take a look before this can be merged.

@cottsay cottsay mentioned this pull request Jun 15, 2023
Merged
@cottsay cottsay merged commit b6f5b43 into rolling Jun 21, 2023
14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/ament_vendor branch June 21, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@clalancette clalancette Awaiting requested review from clalancette

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees

@cottsay cottsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cottsay @emersonknapp