Update to use yaml-cpp version 0.8.0.

[clalancette]

In yaml-cpp 0.8.0, they updated to use a proper CMake target, i.e. yaml-cpp::yaml-cpp. Update that here as well since we are updating our vendor to 0.8.0.

While I was in here, I did a bunch of cleanup to make fewer symbols externally visible.

Let me know if you want me to split the cleanups out into a separate PR; I'm happy to do that.

Depends on ros2/yaml_cpp_vendor#48 , so should not be merged before that one.

[MichaelOrlov]

@clalancette Thanks for cleanups. LGTM with green CI.

[ahcorde]

• Linux
• Linux-aarch64
• Windows
• Windows Debug
• RHEL-9

[jyjblrd]

Hi, this is causing my builds to fail with the error:

CMake Error at /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock_executable.cmake:50 (add_executable):
  Target "test_qos" links to target "yaml-cpp::yaml-cpp" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock_executable.cmake:37 (_ament_add_gmock_executable)
  /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock.cmake:65 (ament_add_gmock_executable)
  CMakeLists.txt:129 (ament_add_gmock)

Pulling from the commit before this one resolves this issue. I noticed that the automated builds are also failing with this issue?

[clalancette]

Pulling from the commit before this one resolves this issue. I noticed that the automated builds are also failing with this issue?

Yeah, that will be the case until we do releases of all 4 of the connected PRs. Given that we are just 2.5 working days from the freeze, we'll probably wait until Tuesday, April 16 to do that. Until then, you'll have to build this along with ros2/yaml_cpp_vendor#48

[jyjblrd]

Ah, that makes sense. Sorry, was not aware of how ROS handles releases!