Wait for metadata to be written to disk #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmichaels11
approved these changes
Feb 4, 2020
thomas-moulard
suggested changes
Feb 4, 2020
piraka9011
force-pushed
the
wait-for-metadata
branch
from
d4a99b7
to
d873346
Compare
piraka9011
requested review from
thomas-moulard,
zmichaels11,
dabonnie and
emersonknapp
zmichaels11
reviewed
Feb 5, 2020
zmichaels11
approved these changes
Feb 5, 2020
emersonknapp
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
@piraka9011 this looks fine, can you rebase and add DCO signoff so it passes checks?
zmichaels11
reviewed
Feb 7, 2020
piraka9011
force-pushed
the
wait-for-metadata
branch
from
8a81685
to
0a720fc
Compare
thomas-moulard
approved these changes
Feb 7, 2020
| @@ -87,6 +87,24 @@ class RecordFixture : public TemporaryDirectoryFixture | |||
| return root_bag_path_ / (get_bag_file_name(split_index) + ".db3"); | |||
| } | |||
|
|
|||
| void wait_for_metadata(int timeout_in_sec = 5) | |||
There was a problem hiding this comment.
It seems that timeout_in_sec is never used, so we don't need this parameter, we can just set 5 as a constant.
https://martinfowler.com/bliki/Yagni.html
There was a problem hiding this comment.
Would it make sense to define it as a constant somewhere or just use 5 directly?
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Signed-off-by: Anas Abou Allaban <allabana@amazon.com> Co-Authored-By: Zachary Michaels <zmichaels11@users.noreply.github.com>
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
piraka9011
force-pushed
the
wait-for-metadata
branch
from
c82266c
to
15145b7
Compare
|
@ros2/aws-oncall - please run this CI job
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method to the rosbag2 record E2E test fixture to wait until the metadata has been written to disk.
This resolves test flakiness on systems that are slow to flush all file system data to disk.
Signed-off-by: Anas Abou Allaban allabana@amazon.com