Refactor record_fixture to use rcpputils::fs::path #286
Conversation
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
|
|
||
| rcpputils::fs::path get_bag_file_path(int split_index) | ||
| { | ||
| return root_bag_path_ / (get_bag_file_name(split_index) + ".db3"); |
There was a problem hiding this comment.
This assumes an SQLite storage plugin only.
There was a problem hiding this comment.
Correct, however the tests only operate on sqlite storage plugin.
There was a problem hiding this comment.
I see that it's just moving from https://github.com/ros2/rosbag2/pull/286/files#diff-3609b823f2d4cae7c0418a8efe81cc96L50 - it's out of scope for this PR but we should think about how this test can run against arbitrary plugins
There was a problem hiding this comment.
@zmichaels11 can you file an issue?
|
@ros2/aws-oncall - please run this CI job |
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
|
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
|
Rebuilding with unique bag file paths. See #281
Edit: |
Changes
rcpputils::fs::pathinstead ofstd::stringfor paths held internally byRecordFixtureroot_bag_path_is now anrcpputils::fs::pathinstead of anstd::stringget_bag_file_name(split_index)which returns the name of the split bag file.get_bag_file_path(split_index)which returns the relative path to the split bag file.This refactoring PR is to reduce the changes required for #281
Signed-off-by: Zachary Michaels zmichaels11@gmail.com