Replace rcutils_get_file_size with rcpputils::fs::file_size #291
Conversation
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
| @@ -71,7 +71,8 @@ std::vector<uint8_t> get_input_buffer(const std::string & uri) | |||
| throw std::runtime_error{errmsg.str()}; | |||
| } | |||
|
|
|||
| const auto decompressed_buffer_length = rcutils_get_file_size(uri.c_str()); | |||
| const auto file_path = rcpputils::fs::path{uri}; | |||
| const auto decompressed_buffer_length = file_path.exists() ? file_path.file_size() : 0; | |||
There was a problem hiding this comment.
you might want to use 0u here and below. You've done this in the change before as well.
|
@ros2/aws-oncall - please run this CI job |
|
|
It looks like the macOS CI is currently broken due to infrastructure. |
|
Restarting CI:
|
|
Status update: Edit:
|
|
Merging because this is passing on all systems. |
Changes
rcutils_file_sizewithrcpputils::fs::file_sizestd::removewithrcpputils::fs::removeNotes:
rcutils_file_sizereturns 0ul when the file does not exist whilercpputils::fs::file_sizethrows. Because of this, all changes in this PR must checkexistsbefore invokingfile_size.ASSERT_TRUEonrcpputils::fs::path::existsinstead of branching on it before invokingrcpputils::fs::path::file_size. All asserts include a message to state that the expected path does not exist.