Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use streaming for compression #295

Closed
piraka9011 opened this issue Feb 13, 2020 · 1 comment · Fixed by #543
Closed

Use streaming for compression #295

piraka9011 opened this issue Feb 13, 2020 · 1 comment · Fixed by #543
Labels
enhancement New feature or request

Comments

@piraka9011
Copy link
Contributor

Description

The current implementation of compression with Zstd loads a file into memory and compresses in place. A better solution would be to use Zstd's compressStream feature which reads data in buffers. This enables rosbag2 to generate and compress large bag files on memory constrained systems.

Completion Criteria

  • Refactor rosbag2_compression::zstd_de/compressor to use zstd's ZSTD_de/compressStream API.

Testing Notes / Suggestions

  • Previous unit tests should pass.
@piraka9011 piraka9011 added the enhancement New feature or request label Feb 13, 2020
@pjreed
Copy link
Contributor

pjreed commented Sep 15, 2020

Since this is in an area of the code I've been working on lately anyway, I can take a look at implementing this.

@pjreed pjreed mentioned this issue Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ZSTD's streaming interface for compressing files pjreed/rosbag2
2 participants
@pjreed @piraka9011