Test all RMW implementations for rosbag2_transport #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersonknapp
requested review from
Karsten1987,
ivanpauno,
piraka9011 and
thomas-moulard
emersonknapp
force-pushed
the
emersonknapp/test_all_rmw_implementations
branch
from
4d52dde
to
d7bafb0
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/test_all_rmw_implementations
branch
from
d7bafb0
to
bc07f7e
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/test_all_rmw_implementations
branch
from
bc07f7e
to
2649ea0
Compare
21 tasks
piraka9011
approved these changes
Apr 3, 2020
thomas-moulard
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
+1 on Anas comment, see e.g. how https://github.com/ros2/rmw/blob/master/rmw_implementation_cmake/cmake/call_for_each_rmw_implementation.cmake is documented, we should do the same for each function/macro we introduce. Consider also moving those functions into a separate cmake file so that the CMakeLists.txt is free of clutter.
ivanpauno
approved these changes
Apr 3, 2020
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
|
Ok - I moved it to a separate file and added documentation |
|
delete-merged-branch
bot
deleted the
emersonknapp/test_all_rmw_implementations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ament/ament_cmake#236 - there is a bug in
ament_add_gmockthat shows up when I start usingENVIterate over all RMW implementations for the rosbag2_transport tests, because it's been the case recently that some tests will pass on fastrtps but fail on cyclonedds.