reenable cppcheck for rosbag2_transport

[Karsten1987]

I wasn't aware of it and not sure why it got disabled in the first place, but with the following patch cppcheck passes successfully locally on my OSX.
Alternatively, one can place a // cppcheck-suppress unknownMacro above the two RCLCPP macros.

This PR was inspired by ros2/rclpy#577

CI (only testing cppcheck within rosbag2_transport):

• Linux
• Linux-aarch64
• macOS
• Windows

[Karsten1987]

it makes me a bit nervous that the GitHub actions (at least the linters) are all passing even though cppcheck was clearly complaining wo/ this patch.
@emersonknapp Do we have to bump them to a new version?

[emersonknapp]

I just checked and realized that the linters are running the version from Eloquent - #463 should clear that up

[emersonknapp]

I was realizing on #463 that I had to disable cppcheck for rosbag2_transport in the Action configuration - I tried incorporating this fix, but invoking the linter from outside of CMake seems to not take it into account. I think I'll need to leave the action-ros-lint cppcheck configuration disabled, and just expect to see it in the regular builds.

[Karsten1987]

Would you prefer to use the alternative solution to this problem and explicitly disable the unknownMacro for the two places inline? I have no problem with that either.

[emersonknapp]

I think I like that better. Linters feel like they should be able to operate without being involved in the build system.

If the macro really couldn't be found - the build wouldn't pass

[Karsten1987]

• Linux
• Linux-aarch64
• macOS
• Windows

[Karsten1987]

Seems like the windows jenkins CI had a hiccup here. Given that I am testing only cppcheck and it's passing on all other platforms, I consider this good to go. Merging ...

[emersonknapp]

Looks like Jenkins triggered the rebuild too?

I don't fully understand how they tie together, but usually when the worker just crashes like that, I see an identical build that doesn't seem like a human actually started it.