Update codes since rcutils_calculate_directory_size() is changed #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
requested review from
emersonknapp and
Karsten1987
and removed request for
a team
|
This change is related to ros2/rcutils#306. |
clalancette
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
Seems reasonable to me once ros2/rcutils#306 goes in. Note that the PR job is going to fail here until we merge and release 306.
emersonknapp
approved these changes
Dec 1, 2020
|
CI for this is over in ros2/rcutils#306 (comment) . With that, merging alongside #306 |
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
Signed-off-by: Barry Xu <barry.xu@sony.com>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
Signed-off-by: Barry Xu <barry.xu@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.