Stay compliant with std::filesystem API #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bject Signed-off-by: Josh Langsfeld <josh.langsfeld@gmail.com>
jdlangs
requested review from
thomas-moulard and
jikawa-az
and removed request for
a team
emersonknapp
approved these changes
Jan 4, 2021
|
Gist: https://gist.githubusercontent.com/emersonknapp/e3b7ca277fa3c7dc6acdc98059d8a288/raw/c61d5fbdd986a9f9af1280ed4e6d5476da775166/ros2.repos
|
adamdbrw
pushed a commit
that referenced
this pull request
Jan 14, 2021
…bject (#593) Signed-off-by: Josh Langsfeld <josh.langsfeld@gmail.com>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
…bject (#593) Signed-off-by: Josh Langsfeld <josh.langsfeld@gmail.com>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
…bject (#593) Signed-off-by: Josh Langsfeld <josh.langsfeld@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been investigating making the
rcpputils::fsfunctionality more compliant withstd::filesystemin anticipation of switching and came across this use ofpath::exists(), which doesn't exist in std::filesystem. This only changes to the non-member function inrcpputils::fsand so can be merged independent of any other change.