use rosbag2_py for ros2 bag info #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karsten1987
requested review from
thomas-moulard and
prajakta-gokhale
and removed request for
a team
|
emersonknapp
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
This looks fine - one small nitpick on namespace details. I guess the removal of _info from rosbag2_transport could have been a separate change, since adding this to rosbag2_py didn't conflict with that, but I see no reason to take the time if this is working.
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Karsten1987
force-pushed
the
rosbag2_py_info
branch
from
64aa770
to
ea41473
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per title. The
infoverb no longer usesrosbag2_transportbut directly points torosbag2_py.The actual changes are rather simple, the PR grew in size of touched files due to the removal of the info functionality in the transport package.