Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -Werror from CMakeLists.txt, enable it in Action CI #722

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Remove -Werror from CMakeLists.txt, enable it in Action CI #722

merged 1 commit into from
Apr 8, 2021

Conversation

emersonknapp
Copy link
Collaborator

Closes #720

Remove -Werror from builds, enable it in Action CI
8b28ec2 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp requested a review from a team as a code owner April 8, 2021 21:23
@emersonknapp emersonknapp requested review from Karsten1987 and zmichaels11 and removed request for a team April 8, 2021 21:23
@emersonknapp emersonknapp mentioned this pull request Apr 8, 2021
Closed
@emersonknapp emersonknapp changed the title Remove -Werror from builds, enable it in Action CI Remove -Werror from CMakeLists.txt, enable it in Action CI Apr 8, 2021
clalancette
clalancette approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me assuming CI is happy.

Karsten1987
Karsten1987 approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @emersonknapp

@emersonknapp emersonknapp merged commit 6325857 into master Apr 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/no-werror branch April 8, 2021 22:07
Kettenhoax pushed a commit to Kettenhoax/rosbag2 that referenced this pull request Apr 9, 2021
@emersonknapp
Remove -Werror from builds, enable it in Action CI (ros2#722)
953cca1 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@xkaraman xkaraman mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@zmichaels11 zmichaels11 Awaiting requested review from zmichaels11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove -Werror from CMakeLists.txt
3 participants
@emersonknapp @clalancette @Karsten1987