Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[humble] Don't crash when type definition cannot be found, and find srv defs if available #1398

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

emersonknapp
Copy link
Collaborator

@emersonknapp emersonknapp commented Jun 14, 2023

Part of #1336
Manual Humble backport of #1350 and #1341 combined

Required significant manual changes because the class in question is located in rosbag2_storage_mcap, which slightly different function signatures and a different linter configuration.

…f available

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp requested a review from a team as a code owner June 14, 2023 20:40
@emersonknapp emersonknapp requested review from MichaelOrlov, jhdcs and james-rms and removed request for a team June 14, 2023 20:40
@MichaelOrlov
Copy link
Contributor

@emersonknapp It seems need to add action_msgs in package.xml as dependencies.

13:40:50 --- stderr: rosbag2_storage_mcap_testdata
13:40:50 CMake Error at /opt/ros/humble/share/rosidl_cmake/cmake/rosidl_generate_interfaces.cmake:147 (message):
13:40:50   Unable to generate action interface for 'action/BasicAction.action'.  In
13:40:50   order to generate action interfaces you must add a depend tag for
13:40:50   'action_msgs' in your package.xml.
13:40:50 Call Stack (most recent call first):
13:40:50   CMakeLists.txt:11 (rosidl_generate_interfaces)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Collaborator Author

Pulls: #1398
Gist: https://gist.githubusercontent.com/emersonknapp/145cdf26557a3c14cb13969cb22c3562/raw/3d4c45e5ec85b4f8bc9a4bc2b59c1a3a52d5336b/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_storage_mcap rosbag2_storage_mcap_testdata
TEST args: --packages-above rosbag2_storage_mcap rosbag2_storage_mcap_testdata
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12244

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@russkel
Copy link

russkel commented Jun 14, 2023

@emersonknapp you are the MVP.

Thanks for this.

@emersonknapp emersonknapp merged commit c3456fe into humble Jun 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/unfound-type-no-crash-and-srv-defs branch June 15, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants