Updated zstd to 1.5.5

[ahcorde]

Removed this warning

/root/ros2_ws/build/zstd_vendor/zstd_vendor-prefix/src/zstd_vendor/lib/compress/zstd_compress_superblock.c:412:12: warning: variable 'litLengthSum' set but not used [-Wunused-but-set-variable]
  412 |     size_t litLengthSum = 0;

[clalancette]

Looks good to me with green CI.

Let's put this on the queue to merge after the freeze is lifted.

[MichaelOrlov]

I would prefer to suppress such warnings via compiler flags for vendor package rather than patching third-party library.

[clalancette]

I would prefer to suppress such warnings via compiler flags for vendor package rather than patching third-party library.

I will point out that this is essentially a backport of facebook/zstd#2838 . That said, I really don't feel strongly either way, so we can go with a change to the compiler flags rather than this patch if you prefer.

[MichaelOrlov]

@clalancette @ahcorde Please go with a change to the compiler flags rather than this patch.
Also, I would appreciate it if you would add a short comment for the compiler flag that it settled because variable 'litLengthSum' set but not used. This way we will try to remove this flag in the next version bump.

[ahcorde]

@clalancette With this patch 51924ed the warning is still there, do you know what I'm doing wrong?

[clalancette]

@clalancette With this patch 51924ed the warning is still there, do you know what I'm doing wrong?

This is just a guess, but I believe that the zstd code is C, not C++. So you probably need to set CMAKE_C_FLAGS.

[ahcorde]

I setted "-DCMAKE_C_FLAGS:STRING=${CMAKE_C_FLAGS}" but the error is still there. I included this flag too -DCMAKE_VERBOSE_MAKEFILE=True to debug the commands.

cd /root/ros2_ws/build/zstd_vendor/zstd_vendor-prefix/src/zstd_vendor-build/lib && /usr/bin/clang -DXXH_NAMESPACE=ZSTD_ -DZSTD_LEGACY_SUPPORT=0 -DZSTD_MULTITHREAD -Dlibzstd_shared_EXPORTS -I/root/ros2_ws/build/zstd_vendor/zstd_vendor-prefix/src/zstd_vendor-build/lib -I/root/ros2_ws/build/zstd_vendor/zstd_vendor-prefix/src/zstd_vendor/build/cmake/lib -I/root/ros2_ws/build/zstd_vendor/zstd_vendor-prefix/src/zstd_vendor/build/cmake/../../lib -I/root/ros2_ws/build/zstd_vendor/zstd_vendor-prefix/src/zstd_vendor/build/cmake/../../lib/common -Wno-unused-but-set-variable -std=c99 -Wall -Wextra -Wundef -Wshadow -Wcast-align -Wcast-qual -Wstrict-prototypes -O3 -DNDEBUG -fPIC -MD -MT lib/CMakeFiles/libzstd_shared.dir/root/ros2_ws/build/zstd_vendor/zstd_vendor-prefix/src/zstd_vendor/lib/decompress/huf_decompress.c.o -MF CMakeFiles/libzstd_shared.dir/root/ros2_ws/build/zstd_vendor/zstd_vendor-prefix/src/zstd_vendor/lib/decompress/huf_decompress.c.o.d -o CMakeFiles/libzstd_shared.dir/root/ros2_ws/build/zstd_vendor/zstd_vendor-prefix/src/zstd_vendor/lib/decompress/huf_decompress.c.o -c /root/ros2_ws/build/zstd_vendor/zstd_vendor-prefix/src/zstd_vendor/lib/decompress/huf_decompress.c
/root/ros2_ws/build/zstd_vendor/zstd_vendor-prefix/src/zstd_vendor/lib/compress/zstd_compress_superblock.c:412:12: warning: variable 'litLengthSum' set but not used [-Wunused-but-set-variable]
  412 |     size_t litLengthSum = 0;
      |            ^

and the -Wno-unused-but-set-variable is there but it's not working. any other thoughts @clalancette ?

[clalancette]

So I poked at this a bit. The problem is the way in which zstd constructs the command-line arguments in its CMake code. In particular, it puts -Wall -Wextra after any command-line arguments that the user provides via CMAKE_C_FLAGS, and thus even though we disable the warning with -Wno-unused-but-set-variable, it gets re-enabled by -Wall -Wextra.

I discussed this with @MichaelOrlov and @ahcorde , and we came to agreement to go back to patching the source code, which is the most reliable thing to do here. That is, we can change this PR back to 772aaaa , and go from there. @ahcorde I'll leave this to you to do.

[clalancette]

Looks good to me with green CI.

[MichaelOrlov]

@ahcorde @clalancette I've just realized that instead of patching an old version of the zstd library we need to bump its version to the 1.5.5 which is going to be on noble https://packages.ubuntu.com/noble/zstd. And there this warning should already been fixed.

[MichaelOrlov]

I've double checked that it is fixed on 1.5.5 version https://github.com/facebook/zstd/blob/63779c798237346c2b245c546c40b72a5a5913fe/lib/compress/zstd_compress_superblock.c#L138

[ahcorde]

@MichaelOrlov I updated to version 1.5.5 but there are two new warnings...

[MichaelOrlov]

LGTM

[MichaelOrlov]

@ros-pull-request-builder retest this please

[ahcorde]

• Linux
• Linux-aarch64
• Windows
• Linux clang

[ahcorde]

• Windows

[ahcorde]

• Windows

[ahcorde]

• Windows

[ahcorde]

• Windows

[ahcorde]

• Windows

[ahcorde]

• Linux
• Linux-aarch64
• Windows
• Linux

[ahcorde]

https://github.com/Mergifyio backport jazzy

[mergify]

backport jazzy

✅ Backports have been created

• #1624 Updated zstd to 1.5.5 (backport #1617) has been created for branch jazzy