Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/use converters in writer iterations #66

Merged
merged 3 commits into from
Nov 29, 2018
Merged

Feature/use converters in writer iterations #66

merged 3 commits into from
Nov 29, 2018

Conversation

Karsten1987
Copy link
Collaborator

now we turn it around :)

I have three commits I'd like to merge.

  • iterate over the info output
  • use a converter options struct for arguments
  • rename the topic_with_types to topic_metadata

@anhosi
Copy link
Contributor

anhosi commented Nov 29, 2018

lgtm

@Karsten1987 Karsten1987 merged commit 5c1045d into master Nov 29, 2018
@Karsten1987 Karsten1987 deleted the feature/use_converters_in_writer_iterations branch November 29, 2018 09:26
@anhosi anhosi mentioned this pull request Nov 29, 2018
Merged
sriramster pushed a commit to sriramster/rosbag2 that referenced this pull request Feb 28, 2019
@Martin-Idel-SI @Karsten1987
ros2GH-66 Change plugin_development documentation to reflect interfac…
52d5ab3 
…e changes (ros2#29)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karsten1987 @anhosi