Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose pause/resume related services on the Player #729

Merged
merged 6 commits into from
Apr 23, 2021
Merged

Expose pause/resume related services on the Player #729

merged 6 commits into from
Apr 23, 2021

Commits on Apr 22, 2021

  1. Pause/Resume services on Player 

    Signed-off-by: Emerson Knapp <eknapp@amazon.com>
    Emerson Knapp committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    8208eaa View commit details
    Browse the repository at this point in the history

  2. Fix linters 

    Signed-off-by: Emerson Knapp <eknapp@amazon.com>
    Emerson Knapp committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    c9e7968 View commit details
    Browse the repository at this point in the history

  3. Add fixture and tests for playback services 

    Signed-off-by: Emerson Knapp <eknapp@amazon.com>
    Emerson Knapp committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    db3da04 View commit details
    Browse the repository at this point in the history

  4. Make test faster and fix locking logic 

    and add TODO for clock setup in the constructor

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
    Emerson Knapp committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    31d6718 View commit details
    Browse the repository at this point in the history

  5. Pause logic was not being strict enough for our determinism needs - f… 

    …ixed

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
    Emerson Knapp committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    be39616 View commit details
    Browse the repository at this point in the history

  6. Clang reminded me that mutex must be locked before waiting on conditi… 

    …on variable

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
    Emerson Knapp committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    d86bfb8 View commit details
    Browse the repository at this point in the history