Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide MetadataIO interface to convert metadata to a string in memory, alongside file IO versions #894

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

emersonknapp
Copy link
Collaborator

This way storage plugins or other utilities can serialize into a string without having to go to a file.

…y, alongside file IO versions

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp requested a review from a team as a code owner October 27, 2021 19:37
@emersonknapp emersonknapp requested review from MichaelOrlov and david-prody and removed request for a team October 27, 2021 19:37
Copy link
Contributor

@lihui815 lihui815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk

@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/b439c214b03227801d21747a7232a6c5/raw/5ad5682653d485578c3be9e5cc4b9dae91b20842/ros2.repos
BUILD args: --packages-up-to rosbag2_transport
TEST args: --packages-select rosbag2_transport
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/9246

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit df9695c into master Oct 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/string-metadata branch October 27, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants