Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package READMEs and QUALITY_DECLARATIONS for runtime packages #480

Merged
merged 3 commits into from
May 6, 2020
Merged

Package READMEs and QUALITY_DECLARATIONS for runtime packages #480

merged 3 commits into from
May 6, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented May 1, 2020

Signed-off-by: Stephen Brawner brawner@gmail.com

@brawner
Package READMEs and QUALITY_DECLARATIONS for runtime packages
9a5d080 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner force-pushed the brawner/quality_declarations branch from 96fafcd to 9a5d080 Compare May 1, 2020 23:13
ahcorde
ahcorde requested changes May 4, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor fixes

rosidl_runtime_c/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rosidl_runtime_c/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rosidl_runtime_c/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rosidl_runtime_cpp/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rosidl_typesupport_interface/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rosidl_typesupport_interface/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
@brawner
PR Fixup
91492eb 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
ahcorde
ahcorde requested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider to add a small description in the dependencies section for each package.

rosidl_runtime_c/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
@brawner
Add dependency breakdown
da4e2d4 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
ahcorde
ahcorde approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde ahcorde merged commit 84412ce into master May 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/quality_declarations branch May 6, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brawner @ahcorde