Quality Declaration for typesupport_introspection #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Boasson <eb@ilities.com>
clalancette
requested changes
Oct 28, 2021
There was a problem hiding this comment.
@eboasson First, thanks for doing this. I know it is tedious, having done a bunch myself.
Inline I've left a bunch of comments. They are all minor wording changes, so once those are fixed up I think we'll be good to go in getting this in.
Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Erik Boasson <eb@ilities.com>
eboasson
force-pushed
the
typesup-introspection-quality-decl
branch
from
e366d21
to
ae52df7
Compare
|
@clalancette all sensible suggestions and no further changes. Because DCO test failed I've squashed the edits and force-pushed them as a single commit. |
|
@ros-pull-request-builder retest this please |
clalancette
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is derived from the regular
rosidl_typesupport_cppquality declaration, but adapted to the specifics of the introspection type supports. In particular it claims QL3 because of the absence of documentation.