Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up the documentation for rosidl_typesupport_introspection_c #628

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

clalancette
Copy link
Contributor

With these changes, this package now builds without warnings.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

With these changes, this package now builds without warnings.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI and a release note for the API breakage.

@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor Author

@hidmic and I discussed this offline, and we felt that a release note wasn't really required here (a downstream user would have to be using the type with struct in the front). In the interest of keeping the noise in the release notes down, we decided not to put one in for this pretty esoteric problem. With green CI, I'm going to go ahead and merge this.

@clalancette clalancette merged commit b12a9cc into master Nov 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the clalancette/fix-introspection-c-docs branch November 4, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants