Adding tests for unicode support in message comments.

[guichristmann]

This PR is in reference to issue #713.

Adds a new test file test_parse_unicode.py in rosidl_adapter to ensure parsing of messages with Unicode comments works as expected.

The characters and symbols used in the comments were semi-randomly picked from this document: https://www.cogsci.ed.ac.uk/~richard/unicode-sample.html

[clalancette]

CI:

• Linux
• Linux-aarch64
• Windows

[clalancette]

@guichristmann Can you take a look at the flake8 warnings and fix those? I think that import pytest needs to go after the import os block, and that from rosidl_adapter.parser import parse_message_file needs to be before from rosidl_adapter.parser import parse_message_string. Once those are done, I'll run CI again.

[guichristmann]

Oops, seems like I didn't have the flake8 plugin for import order and missed those. I've verified it locally and pushed a new commit with the changes. Hopefully it goes through now.

[clalancette]

Oops, seems like I didn't have the flake8 plugin for import order and missed those. I've verified it locally and pushed a new commit with the changes. Hopefully it goes through now.

Thanks for taking a look. It looks good now; I'll run CI again.

CI:

• Linux
• Linux-aarch64
• Windows

[clalancette]

Thanks for taking a look. It looks good now; I'll run CI again.

Ah, so now we run into a real bug on Windows (it is always Windows). It looks like it is upset about the \u2200 character in one of the tests. If you click on https://ci.ros2.org/job/ci_windows/18571/consoleFull , you should be able to find the error. Can you please take a look?

[guichristmann]

Apparently for Windows it is required to explicitly pass an encoding=utf-8 parameter when writing to a file (per https://stackoverflow.com/questions/27092833/unicodeencodeerror-charmap-codec-cant-encode-characters).

I pushed the small changes that are supposed to fix this, but as I don't have a Windows machine right now I only tested it in Ubuntu. (Is there an alternative way for me to test/run the CI locally?) I'll wait for the new CI run and check again in case new problems pop up.

[clalancette]

I pushed the small changes that are supposed to fix this, but as I don't have a Windows machine right now I only tested it in Ubuntu.

Thanks!

(Is there an alternative way for me to test/run the CI locally?)

Not right now, unfortunately. I'll kick off another round of CI here.

[clalancette]

CI:

• Linux
• Linux-aarch64
• Windows

[clalancette]

Looks good, thanks for iterating!