Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests parsing/generating msg/srv/action comments with non-ASCII characters #713

Closed
gavanderhoorn opened this issue Nov 2, 2022 · 2 comments · Fixed by #720
Closed
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gavanderhoorn
Copy link

As discussed in ros2/rcl_interfaces#147:

[..] tests for non-ascii characters in comments in message files [..]

should be added to the appropriate packages.

ros2/rcl_interfaces#147 removed a couple of unicode apostrophes, which could be seen as having been:

[tests for] support [of] Unicode inside of comments in .msg files [..]

As those characters were removed in ros2/rcl_interfaces#147, proper tests should be added here in ros2/rosidl to replace them.

@guichristmann
Copy link
Contributor

I'd like to try this if no else has yet.

Would it be enough to add a new test file under rosidl_adapter e.g. test_parse_message_with_unicode_comments.py in similar style to the other tests there and make sure the parser can handle comments with unicode characters? Appreciate if you could provide more context that I might be missing.

@clalancette
Copy link
Contributor

Yes, I think that would be the best thing. Add a new test file into rosidl_adapter that tests out unicode comments. Thanks for taking this on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants