Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the C++ version to 17. #761

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Set the C++ version to 17. #761

merged 1 commit into from
Aug 10, 2023

Conversation

clalancette
Copy link
Contributor

Even though this is a C package, we still use C++
for the tests. So we should set the version to C++17.

@clalancette
Set the C++ version to 17.
b35667f 
Even though this is a C package, we still use C++
for the tests.  So we should set the version to C++17.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit b854136 into rolling Aug 10, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/update-to-c++17 branch August 10, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clalancette @mjcarroll