Fix same named types overriding typesources #759
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
requested review from
adityapande-1995,
methylDragon,
quarkytale and
sloretz
as code owners
| @@ -34,6 +34,7 @@ if(BUILD_TESTING) | |||
| ${test_interface_files_ACTION_FILES} | |||
| ${test_interface_files_MSG_FILES} | |||
| ${test_interface_files_SRV_FILES} | |||
| msg/BasicIdl.idl | |||
There was a problem hiding this comment.
Just to be totally clear, this is an unrelated test, correct? I'm actually fine with adding it in here for testing purposes, but I just want to make sure I'm not missing something.
There was a problem hiding this comment.
I just wanted to make extra sure, here in rosidl repo, that the new changes didn't break anything for .idl files, which are handled slightly differently as they don't go through rosidl_adapter. The intention for this extra file is to serve that purpose, since there were not yet any .idl files being tested by this package.
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
|
Pulls: #759
|
|
@Mergifyio backport iron |
✅ Backports have been created
|
* Fix same named types overriding typesources Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> (cherry picked from commit 89c6713)
When two interface types in the same package had the same name stem (e.g.
msg/Empty.msgandsrv/Empty.srv), both types would receive the sameTypeSources in their generated description. Can be considered undefined behavior, but it's processed alphabetically so themsgconsistently received thesrvsources.This fixes it, adds a regression test, and adds a new basic test for
.idlfiles just to make sure that continues to work OK.Bug exists in Iron, this would need to be backported.