Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service introspection] service_msgs dependency #24

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

ihasdapie
Copy link
Member

Services now depend on service_msgs, adding to rosidl_defaults to forward the dependency to packages that generate interfaces.

ros2/ros2#1285

Signed-off-by: Brian Chen brian.chen@openrobotics.org

@ihasdapie ihasdapie mentioned this pull request Aug 27, 2022
14 tasks
@jacobperron jacobperron self-assigned this Sep 1, 2022
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@jacobperron
Copy link
Member

rebased on rolling

Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
@clalancette
Copy link
Contributor

CI for this is in ros2/ros2#1285 (comment)

@clalancette clalancette merged commit a3f753d into rolling Feb 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the service_introspection branch February 2, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants