Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing generated import order #173

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Fixing generated import order #173

merged 2 commits into from
Jul 15, 2022

Conversation

quarkytale
Copy link
Contributor

The sorting order for the module names changes after the call to convert_camel_case_to_lower_case_underscore.
So copied the converted names to another variable and sorting those final names before writing to the file.
See #171 for details.

@quarkytale
sorting after conversion
1e57ddf 
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
@quarkytale quarkytale linked an issue Jul 13, 2022 that may be closed by this pull request
Generated file may fail flake8 import order #171
Closed
@quarkytale quarkytale mentioned this pull request Jul 13, 2022
Merged
@quarkytale
fix flake
2a78b2c 
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
@sloretz
Copy link
Contributor

sloretz commented Jul 14, 2022

When you run CI, I'd recommend running tests on --packages-above rosidl_generator_py. That will make sure we run linter tests on all the downstream interface packages.

@quarkytale
Copy link
Contributor Author

ci_linux Build Status

@quarkytale
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@quarkytale quarkytale merged commit 8d1843e into rolling Jul 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the quarkytale/fix_import_order branch July 15, 2022 09:32
@quarkytale
Copy link
Contributor Author

@Mergifyio backport galactic

@mergify mergify bot mentioned this pull request Jul 15, 2022
Merged
@mergify
Copy link

mergify bot commented Jul 15, 2022

backport galactic

✅ Backports have been created

quarkytale added a commit that referenced this pull request Jul 21, 2022
@quarkytale
Merge pull request #175 from ros2/mergify/bp/galactic/pr-173
5a2d762 
Fixing generated import order (backport #173)
@chapulina chapulina mentioned this pull request Aug 29, 2022
Closed
2 tasks
@quarkytale
Copy link
Contributor Author

@Mergifyio backport humble

@mergify mergify bot mentioned this pull request Sep 1, 2022
Merged
@mergify
Copy link

mergify bot commented Sep 1, 2022

backport humble

✅ Backports have been created

quarkytale added a commit that referenced this pull request Sep 2, 2022
@mergify @quarkytale
Fixing generated import order (backport #173) (#183)
eb847a0 
* sorting after conversion

Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
(cherry picked from commit 1e57ddf)

* fix flake

Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
(cherry picked from commit 2a78b2c)

Co-authored-by: Dharini Dutia <dharini@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiggs gbiggs gbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated file may fail flake8 import order
3 participants
@quarkytale @sloretz @gbiggs