Skip to content

Remove NoReturn #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

Remove NoReturn #229

merged 1 commit into from
Aug 8, 2025

Conversation

InvincibleRMC
Copy link
Contributor

Description

Due to problems with NoReturn remove them for now in place of None. See python/mypy#14044

Tracked in #228

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

@InvincibleRMC
Remove NoReturn for now
4236ff6 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC InvincibleRMC mentioned this pull request Aug 7, 2025
Open
@christophebedard christophebedard self-requested a review August 7, 2025 21:11
wjwwood
wjwwood approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood
Copy link
Member

wjwwood commented Aug 7, 2025

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Member

Pulls: #229
Gist: https://gist.githubusercontent.com/christophebedard/e6add3e05631bdcc23e85ad007cf5921/raw/4974f57e181224385d5b4e8842787d215661c9cc/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_python
TEST args: --packages-above rosidl_python
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16679

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Member

christophebedard commented Aug 7, 2025 •
edited
Loading

argh, I saw that the first CI run above failed because it used "rosidl_python" as the package name, which doesn't exist, and I did the same thing 🤦‍♂️

@christophebedard
Copy link
Member

Pulls: #229
Gist: https://gist.githubusercontent.com/christophebedard/bd2378ab449ed2365587af42e175bbb5/raw/4974f57e181224385d5b4e8842787d215661c9cc/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16680

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit e4c419f into ros2:rolling Aug 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjwwood wjwwood wjwwood approved these changes

@christophebedard christophebedard christophebedard approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@InvincibleRMC @wjwwood @christophebedard @fujitatomoya